Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated repository URL to address broken npm images #1197

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Updated repository URL to address broken npm images #1197

merged 1 commit into from
Jun 5, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 5, 2017

Issue: #1196

What I did

Updated repository URL to address broken npm images.

How to test

  1. I'm not sure how to test this other than just merging and releasing
  2. I'm not sure whether any other tools depend on the old repository structure
  3. The new structure looks valid per NPM docs: https://docs.npmjs.com/files/package.json#repository
  4. The old structure does not look valid?

@shilman shilman requested a review from ndelangen June 5, 2017 13:52
@codecov
Copy link

codecov bot commented Jun 5, 2017 •
edited
Loading

Codecov Report

Merging #1197 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1197   +/-   ##
=======================================
  Coverage   13.31%   13.31%           
=======================================
  Files         199      199           
  Lines        4589     4589           
  Branches      620      613    -7     
=======================================
  Hits          611      611           
- Misses       3444     3446    +2     
+ Partials      534      532    -2
Impacted Files Coverage Δ
app/react/src/client/preview/init.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/config_api.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 49.42% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
app/react/src/server/iframe.html.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.41% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.14% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 30.13% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e1675...5ec0dad. Read the comment docs.

xavxyz
xavxyz approved these changes Jun 5, 2017
View reviewed changes
Copy link
Member

@xavxyz xavxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I believe the old syntax git+ was to have an alternative install between git and https.

@xavxyz xavxyz merged commit 77b68a5 into master Jun 5, 2017
@shilman shilman deleted the 1196-broken-npm-images branch June 5, 2017 14:48
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Jun 7, 2017
@ndelangen ndelangen added this to the v3.0.2 milestone Jun 7, 2017
@shilman shilman added documentation and removed maintenance User-facing maintenance tasks labels Jun 9, 2017
orangecms added a commit to coalmines/coalmines-web that referenced this pull request Feb 13, 2021
@orangecms
Update indui repository URL to fix broken images on npmjs
d4e54f8 
See also storybookjs/storybook#1197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavxyz xavxyz xavxyz approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen ndelangen is a code owner

@aaronmcadam aaronmcadam Awaiting requested review from aaronmcadam aaronmcadam is a code owner

@tmeasday tmeasday Awaiting requested review from tmeasday tmeasday is a code owner

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
v3.1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@shilman @xavxyz @arunoda @ndelangen